Skip to content

Conversation

@nehajoshinj
Copy link

@nehajoshinj nehajoshinj commented Nov 7, 2025

This tests is not fixable and reproducible. The only thing we can do in order to minimize intermittent failures is increasing the retry count and adding a thread.sleep() before retrying.

Reason for adding the Thread.sleep()
This issue is happening under load and other tests might take the port, as there is no visibility between tests. Sleep should increase the chances of these tests releasing the port.

Old PR link for the reference :- #19358


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8334928: Test sun/security/ssl/SSLSocketImpl/ReuseAddr.java failed: java.net.BindException: Address already in use (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28198/head:pull/28198
$ git checkout pull/28198

Update a local copy of the PR:
$ git checkout pull/28198
$ git pull https://git.openjdk.org/jdk.git pull/28198/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28198

View PR using the GUI difftool:
$ git pr show -t 28198

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28198.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2025

👋 Welcome back nehajoshinj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8334928: Test sun/security/ssl/SSLSocketImpl/ReuseAddr.java failed: java.net.BindException: Address already in use 8334928: Test sun/security/ssl/SSLSocketImpl/ReuseAddr.java failed: java.net.BindException: Address already in use Nov 7, 2025
@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 7, 2025
@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@nehajoshinj The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2025

Webrevs

@myankelev
Copy link
Member

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants