8371425: Include folder names in vscode workspace virtual folders

[krk]

Include top-level folder name in the source root, to help distinguishing different vscode instances and include the build configuration name in the "Build artifacts" virtual folder name in vscode, in the generated workspace file from make vscode-project.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8371425: Include folder names in vscode workspace virtual folders (Enhancement - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Jorn Vernee (@JornVernee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28194/head:pull/28194
$ git checkout pull/28194

Update a local copy of the PR:
$ git checkout pull/28194
$ git pull https://git.openjdk.org/jdk.git pull/28194/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28194

View PR using the GUI difftool:
$ git pr show -t 28194

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28194.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back krk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@krk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371425: Include folder names in vscode workspace virtual folders

Reviewed-by: erikj, jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 066810c: 8371485: ProblemList awt/Mixing/AWT_Mixing/JTableInGlassPaneOverlapping.java for linux
• 2c3c470: 8354548: Update CLDR to Version 48.0
• 9bc2360: 8371364: Refactor javax/swing/JFileChooser/FileSizeCheck.java to use Util.findComponent()
• ... and 4 more: https://git.openjdk.org/jdk/compare/167c952bb0fefb5acc9782f4f4474d92097c93f8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @JornVernee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@krk The following labels will be automatically applied to this pull request:

• build
• ide-support

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9f39f939)
• 00: Full (f0145f45)

[erikj79]

I think this change makes sense, but it would be good to get input from other VS Code users.

[erikj79]

These lines aren't lining up with the rest. Please see https://openjdk.org/groups/build/doc/code-conventions.html for details on build system code conventions.

[erikj79]

/reviewers 2

[openjdk]

@erikj79
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[JornVernee]

As a VS Code user I welcome this change. The current folder names are fairly nondescript.