Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 7, 2025

TestEmergencyDumpAtOOM.java fails on ppc64 platforms because of issues with the emergency writing of a jfr file in crash cases.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371473: Problem list TestEmergencyDumpAtOOM.java on ppc64 platforms related to JDK-8371014 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28193/head:pull/28193
$ git checkout pull/28193

Update a local copy of the PR:
$ git checkout pull/28193
$ git pull https://git.openjdk.org/jdk.git pull/28193/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28193

View PR using the GUI difftool:
$ git pr show -t 28193

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28193.diff

Using Webrev

Link to Webrev Comment

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371473: Problem list TestEmergencyDumpAtOOM.java on ppc64 platforms related to JDK-8371014

Reviewed-by: mdoerr, phubner

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8371473: Problem list TestEmergencyDumpAtOOM.java on ppc64 platforms related to JDK-8371014 8371473: Problem list TestEmergencyDumpAtOOM.java on ppc64 platforms related to JDK-8371014 Nov 7, 2025
@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@MBaesken To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@TheRealMDoerr
Copy link
Contributor

/label add hotspot-jfr

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Nov 7, 2025
@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@TheRealMDoerr
The hotspot-jfr label was successfully added.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 7, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-jfr hotspot-jfr-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants