8371383: Test sun/security/tools/jarsigner/DefaultOptions.java failed due to CertificateNotYetValidException

[haimaychao]

The DefaultOptions.java test may fail as the current system time is before the signing certificate NotBefore time, when jarsigner tool validates it in CertificateValidity.valid(). Please review the fix in this test to avoid such intermittent timing problem. Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371383: Test sun/security/tools/jarsigner/DefaultOptions.java failed due to CertificateNotYetValidException (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28186/head:pull/28186
$ git checkout pull/28186

Update a local copy of the PR:
$ git checkout pull/28186
$ git pull https://git.openjdk.org/jdk.git pull/28186/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28186

View PR using the GUI difftool:
$ git pr show -t 28186

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28186.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back hchao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@haimaychao The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (55c83609)
• 00: Full (606341e3)

[myankelev]

Minor: This is a test issue, could you please remove the bug id from here, as it only tracks product ones?

[haimaychao]

Removed the bug id.

[myankelev]

I wonder if it wouldn't be cleaner to add -startdate -1M to the cert gen instead of sleeping in the test. similar to this pr.

What do you think?

[haimaychao]

Updated code as suggested.