-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8370039: GenShen: array copy SATB barrier improvements #28183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@earthling-amzn The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
When an array copy happens concurrently with old and young marking, Shenandoah's generational mode walks over the array twice. This is unnecessary and increases the workload for marking threads. It also has been unconditionally enqueuing old references during a young mark. This is also unnecessary and also increases marking workload. Finally, the barrier went through a somewhat complicated decision process based on affiliation of the region where the array resides. However, the barrier must consider the affiliation of objects that are pointed at by array elements.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28183/head:pull/28183$ git checkout pull/28183Update a local copy of the PR:
$ git checkout pull/28183$ git pull https://git.openjdk.org/jdk.git pull/28183/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28183View PR using the GUI difftool:
$ git pr show -t 28183Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28183.diff
Using Webrev
Link to Webrev Comment