Skip to content

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Nov 6, 2025

This is a leftover when we introduced "dayperiods" in the JDK (JDK-8247781). The CLDR Converter was modified to generate patterns for SimpleDateFormat for dayperiods (simply replacing them with ampm), and the same processing should have been applied to Host provider on mac, which also uses LDML patterns. As in the bug report, macos recently started using dayperiods, thus the issue was revealed. Regression test is not provided as it would require the macos's default locale should be configured to zh_TW. I have manually confirmed that the proposed fix would work for the problem case.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371339: Illegal pattern char 'B' with locale.providers as HOST on macOS for Taiwanese (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28181/head:pull/28181
$ git checkout pull/28181

Update a local copy of the PR:
$ git checkout pull/28181
$ git pull https://git.openjdk.org/jdk.git pull/28181/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28181

View PR using the GUI difftool:
$ git pr show -t 28181

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28181.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2025

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 6, 2025
@openjdk
Copy link

openjdk bot commented Nov 6, 2025

@naotoj The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2025
@naotoj
Copy link
Member Author

naotoj commented Nov 6, 2025

/label add i18n

@openjdk openjdk bot added the i18n i18n-dev@openjdk.org label Nov 6, 2025
@openjdk
Copy link

openjdk bot commented Nov 6, 2025

@naotoj
The i18n label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 6, 2025

Webrevs

Copy link
Member

@justin-curtis-lu justin-curtis-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Case handling for day period looks the same as in cldrconverter/Bundle.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants