8371339: Illegal pattern char 'B' with locale.providers as HOST on macOS for Taiwanese #28181
+12
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a leftover when we introduced "dayperiods" in the JDK (JDK-8247781). The CLDR Converter was modified to generate patterns for SimpleDateFormat for dayperiods (simply replacing them with ampm), and the same processing should have been applied to Host provider on mac, which also uses LDML patterns. As in the bug report, macos recently started using dayperiods, thus the issue was revealed. Regression test is not provided as it would require the macos's default locale should be configured to zh_TW. I have manually confirmed that the proposed fix would work for the problem case.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28181/head:pull/28181$ git checkout pull/28181Update a local copy of the PR:
$ git checkout pull/28181$ git pull https://git.openjdk.org/jdk.git pull/28181/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28181View PR using the GUI difftool:
$ git pr show -t 28181Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28181.diff
Using Webrev
Link to Webrev Comment