-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8370024: HttpClient: QUIC congestion controller doesn't implement pacing #28156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@djelinski The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Implement pacing for QUIC.
This is required by RFC 9002. Also, it improves the network utilization on links with long round-trip times.
The pacing algorithm itself was created based on the suggestions found in RFC 9002, and on the description of the Linux pacing algorithm.
Pacing is enabled when the round-trip time is less than twice the period at which the selector timeout fires. On Linux the selector timeout fires every millisecond, on Windows it's 15.6 milliseconds by default.
HttpClient tests came back clean.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28156/head:pull/28156$ git checkout pull/28156Update a local copy of the PR:
$ git checkout pull/28156$ git pull https://git.openjdk.org/jdk.git pull/28156/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28156View PR using the GUI difftool:
$ git pr show -t 28156Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28156.diff
Using Webrev
Link to Webrev Comment