8366477: Refactor AOT-related flag bits in klass.hpp

[iklam]

This PR is one (of many) steps in JDK-8366473 (Refactor CDS source code with new AOT terminology):

1. Rename from Klass::_shared_class_flags to Klass::_aot_class_flags
2. Move _has_aot_safe_initializer and _is_runtime_setup_required from InstanceKlassFlags (has run out of bits) to here (we still have 7 extra bits left), to accommodate future @AOTXXX annotations.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8366477: Refactor AOT-related flag bits in klass.hpp (Sub-task - P4)

Reviewers

• Chen Liang (@liach - Reviewer) 🔄 Re-review required (review applies to 08d02072)
• Vladimir Kozlov (@vnkozlov - Reviewer) 🔄 Re-review required (review applies to 08d02072)
• Ashutosh Mehra (@ashu-mehra - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27018/head:pull/27018
$ git checkout pull/27018

Update a local copy of the PR:
$ git checkout pull/27018
$ git pull https://git.openjdk.org/jdk.git pull/27018/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27018

View PR using the GUI difftool:
$ git pr show -t 27018

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27018.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into pr/27017 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full (42dc0711)
• 01: Full - Incremental (08d02072)
• 00: Full (709d3d23)

[liach]

Looks helpful.

[vnkozlov]

Good.

[ashu-mehra]

does it make sense to rename _is_generated_shared_class to _is_generated_aot_class?

[liach]

_is_aot_generated_class sounds better.

[iklam]

I changed it to _is_aot_generated_class

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8366477-refactor-aot-related-flag-bits-in-klass-hpp
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@iklam this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8366477-refactor-aot-related-flag-bits-in-klass-hpp
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

⚠️ @iklam This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[ashu-mehra]

lgtm