8365175: Replace Unicode extension anchor elements with link tag #26996
Conversation
|
👋 Welcome back jlu! A progress list of the required criteria for merging this PR into |
|
@justin-curtis-lu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 32 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@justin-curtis-lu The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
openjdk
bot
added
core-libs
Webrevs
|
| @@ -1647,7 +1647,7 @@ public static Calendar getInstance(TimeZone zone) | |||
| * in the default time zone with the given locale. | |||
| * <p> | |||
| * If the locale contains the time zone with "tz" | |||
| * <a href="Locale.html#def_locale_extension">Unicode extension</a>, | |||
| * {@link Locale##def_locale_extensionUnicode extension}, | |||
| @@ -101,8 +101,8 @@ | |||
| * </blockquote> | |||
| * | |||
| * <p>If the specified locale contains "ca" (calendar), "rg" (region override), | |||
| * and/or "tz" (timezone) <a href="../util/Locale.html#def_locale_extension">Unicode | |||
| * extensions</a>, the calendar, the country and/or the time zone for formatting | |||
| * and/or "tz" (timezone) {@link Locale##def_locale_extension Unicode | |||
There was a problem hiding this comment.
{@link} renders in code font. Is that intended? You can use {@linkplain} for plain font.
There was a problem hiding this comment.
You are right, these would be better as linkplain tags. Updated as such.
| @@ -2667,7 +2667,7 @@ private AvailableCalendarTypes() { | |||
| * @return the LDML-defined calendar type or the class name of this | |||
| * {@code Calendar} instance | |||
| * @since 1.8 | |||
| * @see <a href="Locale.html#def_extensions">Locale extensions</a> | |||
| * @see Locale##def_locale_extension Locale extensions | |||
There was a problem hiding this comment.
This will be handled as plain text because of space in "Locale extensions" 👍
This PR is a cleanup change which replaces anchor element references of the Locale
def_locale_extensionsection with the Javadoc link tag. This is a doc only change and is a result of the discussion in the PR of #26683.This includes one additional conversion of the
legacy_language_codessection to get rid of all Locale.html anchor element references.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26996/head:pull/26996$ git checkout pull/26996Update a local copy of the PR:
$ git checkout pull/26996$ git pull https://git.openjdk.org/jdk.git pull/26996/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26996View PR using the GUI difftool:
$ git pr show -t 26996Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26996.diff
Using Webrev
Link to Webrev Comment