Skip to content

Conversation

abhn-git
Copy link

@abhn-git abhn-git commented Aug 19, 2025

Increase test coverage of ValidateISO4217.java to cover the verifications of numeric code and Fraction Digits of currency codes that are obsolete and do not have related country.

jdk-25.0.1/bin/java -jar jtreg7.5.2/jtreg/lib/jtreg.jar -testjdk:jdk-25.0.1 -dir:jdk-cpu/open/test/jdk/ java/util/Currency/ValidateISO4217.java
Test results: passed: 1
Report written to C:\jck\colocation\JTreport\html\report.html
Results written to C:\jck\colocation\JTwork


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358477: Increase test coverage of ValidateISO4217.java (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26835/head:pull/26835
$ git checkout pull/26835

Update a local copy of the PR:
$ git checkout pull/26835
$ git pull https://git.openjdk.org/jdk.git pull/26835/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26835

View PR using the GUI difftool:
$ git pr show -t 26835

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26835.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 19, 2025

👋 Welcome back abhn-git! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Aug 19, 2025

@abhn-git The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant