-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Jdk 8351073 mods #26357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Jdk 8351073 mods #26357
Conversation
👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@alexeysemenyukoracle The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
396f273
to
8f7ff1d
Compare
@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
8f7ff1d
to
8bf6def
Compare
@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
8bf6def
to
9e492cb
Compare
@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
…of running it for every packaging type (.pkg and .dmg) in every test case. Don't run jlink if external runtime is specified for the test. Remove verifyPKG() as the test doesn't sign .pkg packages (`--mac-installer-sign-identity` is not used in the test). Verify unpacked/installed runtime bundle instead of verifying exploded .dmg packages and not verifying bundle contents inside of .pkg packages.
@alexeysemenyukoracle this pull request can not be integrated into git checkout JDK-8351073-mods
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@alexeysemenyukoracle This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
Progress
Error
Warnings
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26357/head:pull/26357
$ git checkout pull/26357
Update a local copy of the PR:
$ git checkout pull/26357
$ git pull https://git.openjdk.org/jdk.git pull/26357/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26357
View PR using the GUI difftool:
$ git pr show -t 26357
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26357.diff