8359809: AttributeList, RoleList and UnresolvedRoleList should never accept other types of Object

[kevinjwalls]

The classes javax.management.AttributeList, and javax.management.relation.RoleList and UnresolvedRoleList, have a historical feature where they accept objects of the wrong type, and only check for wrong objects when the "asList()" method is called.

This feature should be removed, and these classes should never accept the wrong kind of Object.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8359917 to be approved

Issues

• JDK-8359809: AttributeList, RoleList and UnresolvedRoleList should never accept other types of Object (Enhancement - P4)
• JDK-8359917: AttributeList, RoleList and UnresolvedRoleList should never accept other types of Object (CSR)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25856/head:pull/25856
$ git checkout pull/25856

Update a local copy of the PR:
$ git checkout pull/25856
$ git pull https://git.openjdk.org/jdk.git pull/25856/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25856

View PR using the GUI difftool:
$ git pr show -t 25856

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25856.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359809: AttributeList, RoleList and UnresolvedRoleList should never accept other types of Object

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 143 new commits pushed to the master branch:

• f735275: 8361839: Problemlist BogusFocusableWindowState due to failures in the CI pipeline
• 3d37c4e: 8361693: Remove Klass::clean_subklass_tree()
• 73ab54e: 8360302: Update --release 25 symbol information for JDK 25 build 29
• ... and 140 more: https://git.openjdk.org/jdk/compare/c2d76f9844aadf77a0b213a9169a7c5c8c8f1ffb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kevinjwalls The following labels will be automatically applied to this pull request:

• jmx
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[kevinjwalls]

/csr

[openjdk]

@kevinjwalls has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@kevinjwalls please create a CSR request for issue JDK-8359809 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[kevinjwalls]

Removing the trailing dot from "parameter.", here and new line 247 below, to be in line with the rest.

[mlbridge]

Webrevs

• 05: Full - Incremental (7d3728d4)
• 04: Full - Incremental (a2a28dde)
• 03: Full - Incremental (8b36d3e5)
• 02: Full - Incremental (ab4fef2f)
• 01: Full - Incremental (afb05434)
• 00: Full (50904f10)

[sspitsyn]

Joe asked a question in related CSR. I'm also interested to know the answer. :)

[kevinjwalls]

I will update the CSR to clarify/answer the questions.

I've updated the PR to remove a few checkTypeSafe() calls: they are generally wanted when we add an Object or Collection, but not needed in e.g. an add(Role) method that specifically takes the type that we want. This is why there are api doc additions for the overridden methods that take Object or Collection, and not for the non-overridden add methods that take a specific type (they don't check the type and throw).

[kevinjwalls]

CSR is approved, will need to get re-review or additional review 8-)

[sspitsyn]

It looks good to me now.

[kevinjwalls]

/integrate

[openjdk]

Going to push as commit cbc7090.
Since your change was applied there have been 143 commits pushed to the master branch:

• f735275: 8361839: Problemlist BogusFocusableWindowState due to failures in the CI pipeline
• 3d37c4e: 8361693: Remove Klass::clean_subklass_tree()
• 73ab54e: 8360302: Update --release 25 symbol information for JDK 25 build 29
• ... and 140 more: https://git.openjdk.org/jdk/compare/c2d76f9844aadf77a0b213a9169a7c5c8c8f1ffb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinjwalls Pushed as commit cbc7090.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.