8359423: Improve error message in case of missing jsa shared archive #25846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
eastig
reviewed
Jun 17, 2025
| @@ -1385,7 +1385,7 @@ void MetaspaceShared::initialize_runtime_shared_and_meta_spaces() { | |||
| delete dynamic_mapinfo; | |||
| } | |||
| if (RequireSharedSpaces && has_failed) { | |||
| MetaspaceShared::unrecoverable_loading_error("Unable to map shared spaces"); | |||
| MetaspaceShared::unrecoverable_loading_error("Unable to map shared spaces, but they were required"); | |||
There was a problem hiding this comment.
If you want the message to be more specific, you might need to add whether the failed loading was dynamic or static.
eastig
reviewed
Jun 17, 2025
| @@ -1271,7 +1271,7 @@ void MetaspaceShared::unrecoverable_loading_error(const char* message) { | |||
| } else if (CDSConfig::new_aot_flags_used()) { | |||
| vm_exit_during_initialization("Unable to use AOT cache.", nullptr); | |||
| } else { | |||
| vm_exit_during_initialization("Unable to use shared archive.", nullptr); | |||
| vm_exit_during_initialization("Unable to use shared archive (unrecoverable archive loading error).", nullptr); | |||
There was a problem hiding this comment.
Who not to use message here instead of 'unrecoverable archive loading error'? The default message is 'unrecoverable error'. The default message can be updated to 'unrecoverable archive loading error'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we use
-Xshare:onwith additional flags (regarding coh or coops) and we have the corresponding jsa archive not present,we get this message/error :
The error message could be a little improved, e.g. telling what jsa file is not present .
For example
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25846/head:pull/25846$ git checkout pull/25846Update a local copy of the PR:
$ git checkout pull/25846$ git pull https://git.openjdk.org/jdk.git pull/25846/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25846View PR using the GUI difftool:
$ git pr show -t 25846Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25846.diff
Using Webrev
Link to Webrev Comment