Skip to content

8359436: AOTCompileEagerly should not be diagnostic #25799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/cds/cds_globals.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
product(bool, AOTVerifyTrainingData, trueInDebug, DIAGNOSTIC, \
"Verify archived training data") \
\
product(bool, AOTCompileEagerly, false, DIAGNOSTIC, \
product(bool, AOTCompileEagerly, false, EXPERIMENTAL, \
"Compile methods as soon as possible") \
\
/* AOT Code flags */ \
Expand Down
101 changes: 101 additions & 0 deletions test/hotspot/jtreg/runtime/cds/appcds/aotCache/AOTCompileEagerly.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is aotProfile directory for training data testing.

* Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*
*/


/*
* @test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing * @bug 8359436

* @summary Sanity-check that eager compilation flags are accepted
* @requires vm.cds
* @requires vm.flagless
* @library /test/lib /test/hotspot/jtreg/runtime/cds/appcds/test-classes
* @build Hello
* @run driver jdk.test.lib.helpers.ClassFileInstaller -jar hello.jar Hello
* @run driver AOTCompileEagerly
*/

import java.io.File;
import jdk.test.lib.cds.CDSTestUtils;
import jdk.test.lib.helpers.ClassFileInstaller;
import jdk.test.lib.process.OutputAnalyzer;
import jdk.test.lib.process.ProcessTools;

public class AOTCompileEagerly {
static final String appJar = ClassFileInstaller.getJarPath("hello.jar");
static final String aotConfigFile = "hello.aotconfig";
static final String aotCacheFile = "hello.aot";
static final String helloClass = "Hello";

public static void main(String[] args) throws Exception {
ProcessBuilder pb;
OutputAnalyzer out;

//----------------------------------------------------------------------
System.out.println("Training Run");
pb = ProcessTools.createLimitedTestJavaProcessBuilder(
"-XX:AOTMode=record",
"-XX:AOTConfiguration=" + aotConfigFile,
"-cp", appJar, helloClass);

out = CDSTestUtils.executeAndLog(pb, "train");
out.shouldHaveExitValue(0);

//----------------------------------------------------------------------
System.out.println("Assembly Phase");
pb = ProcessTools.createLimitedTestJavaProcessBuilder(
"-XX:AOTMode=create",
"-XX:AOTConfiguration=" + aotConfigFile,
"-XX:AOTCache=" + aotCacheFile,
"-cp", appJar);
out = CDSTestUtils.executeAndLog(pb, "asm");
out.shouldHaveExitValue(0);

//----------------------------------------------------------------------
System.out.println("Production Run with AOTCache defaults");
pb = ProcessTools.createLimitedTestJavaProcessBuilder(
"-XX:AOTCache=" + aotCacheFile,
"-cp", appJar, helloClass);
out = CDSTestUtils.executeAndLog(pb, "prod-default");
out.shouldHaveExitValue(0);

//----------------------------------------------------------------------
System.out.println("Production Run with AOTCache and eager compilation explicitly ON");
pb = ProcessTools.createLimitedTestJavaProcessBuilder(
"-XX:AOTCache=" + aotCacheFile,
"-XX:+UnlockExperimentalVMOptions",
"-XX:+AOTCompileEagerly",
"-cp", appJar, helloClass);
out = CDSTestUtils.executeAndLog(pb, "prod-eager-on");
out.shouldHaveExitValue(0);

//----------------------------------------------------------------------
System.out.println("Production Run with AOTCache and eager compilation explicitly OFF");
pb = ProcessTools.createLimitedTestJavaProcessBuilder(
"-XX:AOTCache=" + aotCacheFile,
"-XX:+UnlockExperimentalVMOptions",
"-XX:-AOTCompileEagerly",
"-cp", appJar, helloClass);
out = CDSTestUtils.executeAndLog(pb, "prod-eager-off");
out.shouldHaveExitValue(0);
}
}