-
Notifications
You must be signed in to change notification settings - Fork 5.9k
8358102: GenShen: Age tables could be seeded with cumulative values #25535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 70 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@earthling-amzn Unknown command |
@earthling-amzn The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/integrate delegate |
@earthling-amzn Integration of this pull request has been delegated and may be completed by any project committer using the /integrate pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for finding and fixing the issue.
/issue JDK-8358192 |
@ysramakrishna Only the author (@earthling-amzn) is allowed to issue the |
/integrate |
Going to push as commit 99a4b22.
Your commit was automatically rebased without conflicts. |
@earthling-amzn Pushed as commit 99a4b22. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
When dynamic tenuring threshold is disabled, or the age census is configured to be computed during evacuation, the first cohort is seeded with the cumulative counts, rather than the current cycle's counts. This is not the default configuration so this is not an urgent issue.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25535/head:pull/25535
$ git checkout pull/25535
Update a local copy of the PR:
$ git checkout pull/25535
$ git pull https://git.openjdk.org/jdk.git pull/25535/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25535
View PR using the GUI difftool:
$ git pr show -t 25535
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25535.diff