Skip to content

8358102: GenShen: Age tables could be seeded with cumulative values #25535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented May 30, 2025

When dynamic tenuring threshold is disabled, or the age census is configured to be computed during evacuation, the first cohort is seeded with the cumulative counts, rather than the current cycle's counts. This is not the default configuration so this is not an urgent issue.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358102: GenShen: Age tables could be seeded with cumulative values (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25535/head:pull/25535
$ git checkout pull/25535

Update a local copy of the PR:
$ git checkout pull/25535
$ git pull https://git.openjdk.org/jdk.git pull/25535/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25535

View PR using the GUI difftool:
$ git pr show -t 25535

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25535.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2025

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 30, 2025

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358102: GenShen: Age tables could be seeded with cumulative values

Reviewed-by: ysr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 30, 2025

@earthling-amzn Unknown command delegate - for a list of valid commands use /help.

@openjdk
Copy link

openjdk bot commented May 30, 2025

@earthling-amzn The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels May 30, 2025
@earthling-amzn
Copy link
Contributor Author

/integrate delegate

@openjdk openjdk bot added the delegated label May 30, 2025
@openjdk
Copy link

openjdk bot commented May 30, 2025

@earthling-amzn Integration of this pull request has been delegated and may be completed by any project committer using the /integrate pull request command.

Copy link
Member

@ysramakrishna ysramakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for finding and fixing the issue.

@ysramakrishna
Copy link
Member

/issue JDK-8358192

@openjdk
Copy link

openjdk bot commented May 30, 2025

@ysramakrishna Only the author (@earthling-amzn) is allowed to issue the /issue command.

@earthling-amzn earthling-amzn changed the title Use census data from current cycle, rather than cumulative values 8358102: GenShen: Age tables could be seeded with cumulative values Jun 2, 2025
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2025
@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 2, 2025

Going to push as commit 99a4b22.
Since your change was applied there have been 70 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 2, 2025
@openjdk openjdk bot closed this Jun 2, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review delegated labels Jun 2, 2025
@openjdk
Copy link

openjdk bot commented Jun 2, 2025

@earthling-amzn Pushed as commit 99a4b22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jun 2, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants