Skip to content

8357079: Fix Windows AArch64 DevKit Creation #25259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Luigi96
Copy link

@Luigi96 Luigi96 commented May 15, 2025

Fix path for Visual Studio arm64 binaries in createWindowsDevkit.sh

The DevKit currently created on a Windows AArch64 machine uses the x64 compiler binaries (e.g. cl.exe). This can be inspected by running "dumpbin /headers /out:cl.txt cl.exe" on the compiler in the generated DevKit and inspecting the machine architecture line. It should instead use the native Windows AArch64 compiler binaries


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8357079: Fix Windows AArch64 DevKit Creation (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25259/head:pull/25259
$ git checkout pull/25259

Update a local copy of the PR:
$ git checkout pull/25259
$ git pull https://git.openjdk.org/jdk.git pull/25259/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25259

View PR using the GUI difftool:
$ git pr show -t 25259

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25259.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label May 15, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2025

Hi @Luigi96, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Luigi96" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@Luigi96
Copy link
Author

Luigi96 commented May 15, 2025

/covered

@openjdk
Copy link

openjdk bot commented May 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label May 15, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk
Copy link

openjdk bot commented May 15, 2025

@Luigi96 The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant