8357079: Fix Windows AArch64 DevKit Creation #25259
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix path for Visual Studio arm64 binaries in createWindowsDevkit.sh
The DevKit currently created on a Windows AArch64 machine uses the x64 compiler binaries (e.g. cl.exe). This can be inspected by running "dumpbin /headers /out:cl.txt cl.exe" on the compiler in the generated DevKit and inspecting the machine architecture line. It should instead use the native Windows AArch64 compiler binaries
Progress
Error
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25259/head:pull/25259
$ git checkout pull/25259
Update a local copy of the PR:
$ git checkout pull/25259
$ git pull https://git.openjdk.org/jdk.git pull/25259/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25259
View PR using the GUI difftool:
$ git pr show -t 25259
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25259.diff