-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8356971: [JVMCI] Export VM_Version::supports_avx512_simd_sort to JVMCI compiler #25225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into |
@mur47x111 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@mur47x111 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Thanks for the review! Passed tier1-3. |
Going to push as commit 948ade8.
Your commit was automatically rebased without conflicts. |
@mur47x111 Pushed as commit 948ade8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
HotSpot selects between AVX512 and AVX2 implementations of array sort/partition stubs based on the return value of VM_Version::supports_avx512_simd_sort. The AVX2 version supports fewer element types than the AVX512 version and may fail at runtime if unsupported types are encountered. This capability information should be exposed to the JVMCI compiler to properly guard against incorrect intrinsification. This is especially important because VM_Version::supports_avx512_simd_sort includes a special exclusion rule for AMD Zen4, due to performance considerations.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25225/head:pull/25225
$ git checkout pull/25225
Update a local copy of the PR:
$ git checkout pull/25225
$ git pull https://git.openjdk.org/jdk.git pull/25225/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25225
View PR using the GUI difftool:
$ git pr show -t 25225
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25225.diff
Using Webrev
Link to Webrev Comment