Skip to content

8356971: [JVMCI] Export VM_Version::supports_avx512_simd_sort to JVMCI compiler #25225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mur47x111
Copy link
Contributor

@mur47x111 mur47x111 commented May 14, 2025

HotSpot selects between AVX512 and AVX2 implementations of array sort/partition stubs based on the return value of VM_Version::supports_avx512_simd_sort. The AVX2 version supports fewer element types than the AVX512 version and may fail at runtime if unsupported types are encountered. This capability information should be exposed to the JVMCI compiler to properly guard against incorrect intrinsification. This is especially important because VM_Version::supports_avx512_simd_sort includes a special exclusion rule for AMD Zen4, due to performance considerations.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356971: [JVMCI] Export VM_Version::supports_avx512_simd_sort to JVMCI compiler (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25225/head:pull/25225
$ git checkout pull/25225

Update a local copy of the PR:
$ git checkout pull/25225
$ git pull https://git.openjdk.org/jdk.git pull/25225/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25225

View PR using the GUI difftool:
$ git pr show -t 25225

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25225.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2025

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2025

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356971: [JVMCI] Export VM_Version::supports_avx512_simd_sort to JVMCI compiler

Reviewed-by: dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 14, 2025
@openjdk
Copy link

openjdk bot commented May 14, 2025

@mur47x111 The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels May 14, 2025
@mur47x111 mur47x111 changed the title 8356971: [JVMCI] Export VM_Version::supports_avx512_simd_sort to JVMCI compiler. 8356971: [JVMCI] Export VM_Version::supports_avx512_simd_sort to JVMCI compiler May 14, 2025
@mlbridge
Copy link

mlbridge bot commented May 14, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 14, 2025
@mur47x111
Copy link
Contributor Author

Thanks for the review! Passed tier1-3.
/integrate

@openjdk
Copy link

openjdk bot commented May 14, 2025

Going to push as commit 948ade8.
Since your change was applied there have been 8 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 14, 2025
@openjdk openjdk bot closed this May 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 14, 2025
@openjdk
Copy link

openjdk bot commented May 14, 2025

@mur47x111 Pushed as commit 948ade8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants