Skip to content

8355607: Convert binary cert files to base64 #24928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

friedbyalice
Copy link

@friedbyalice friedbyalice commented Apr 28, 2025

The choice of file extension comes from the extension of the existing .cer files that are already in the repository: there are already 19 PEM certificates with a .cer extension


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8355607: Convert binary cert files to base64 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24928/head:pull/24928
$ git checkout pull/24928

Update a local copy of the PR:
$ git checkout pull/24928
$ git pull https://git.openjdk.org/jdk.git pull/24928/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24928

View PR using the GUI difftool:
$ git pr show -t 24928

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24928.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Apr 28, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2025

Hi @friedbyalice, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user friedbyalice" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Apr 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8355607 Convert binary cert files to base64 8355607: Convert binary cert files to base64 Apr 28, 2025
@openjdk
Copy link

openjdk bot commented Apr 28, 2025

@friedbyalice The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oca Needs verification of OCA signatory status security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant