8356843: Avoid redundant HashMap.get to obtain old value in Toolkit.setDesktopProperty

[turbanoff]

To obtain previous value of HashMap we can use result of .put call. In this case we can avoid redundant .get call.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356843: Avoid redundant HashMap.get to obtain old value in Toolkit.setDesktopProperty (Enhancement - P5)

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24691/head:pull/24691
$ git checkout pull/24691

Update a local copy of the PR:
$ git checkout pull/24691
$ git pull https://git.openjdk.org/jdk.git pull/24691/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24691

View PR using the GUI difftool:
$ git pr show -t 24691

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24691.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356843: Avoid redundant HashMap.get to obtain old value in Toolkit.setDesktopProperty

Reviewed-by: aivanov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 500 new commits pushed to the master branch:

• 10436c1: 8356281: Fix for TestFPComparison failure due to incorrect result
• 1afd887: 8356102: TestJcmdOutput, JcmdWithNMTDisabled and DumpSharedDictionary hs/tier1 tests fail on static-jdk
• 97b0dd2: 8336906: C2: assert(bb->is_reachable()) failed: getting result from unreachable basicblock
• ... and 497 more: https://git.openjdk.org/jdk/compare/465c8e658356f658ee04397936f555f6bdffc3c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@turbanoff The following labels will be automatically applied to this pull request:

• client
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[openjdk]

@turbanoff Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[liach]

This field is protected; need evaluation about subclass tempering.

[turbanoff]

It's final. What kind of problems can be from protected field?

[mrserb]

looks fine

[mlbridge]

Webrevs

• 00: Full (194fc044)

[turbanoff]

/integrate

[openjdk]

Going to push as commit e557b69.
Since your change was applied there have been 509 commits pushed to the master branch:

• dc881ee: 8354530: AIX: sporadic unexpected errno when calling setsockopt in Net.joinOrDrop
• 5e50a58: 8356838: AOT incorrectly sets a cached class's loader type to boot
• b66ab8e: 8356693: AOT assembly phase fails with -javaagent
• ... and 506 more: https://git.openjdk.org/jdk/compare/465c8e658356f658ee04397936f555f6bdffc3c2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@turbanoff Pushed as commit e557b69.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.