-
Notifications
You must be signed in to change notification settings - Fork 6k
8345874: Run make doctor automatically on failed CI builds #24485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@magicus This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
/keepalive |
@magicus The pull request is being re-evaluated and the inactivity timeout has been reset. |
If there is something wrong with the build, the user can run "make doctor". That is hard to do in a CI setting. Instead, if the build environment is detected to be a CI, we should run the doctor automatically in case of a failed build.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24485/head:pull/24485
$ git checkout pull/24485
Update a local copy of the PR:
$ git checkout pull/24485
$ git pull https://git.openjdk.org/jdk.git pull/24485/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24485
View PR using the GUI difftool:
$ git pr show -t 24485
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24485.diff
Using Webrev
Link to Webrev Comment