-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8204868: java/util/zip/ZipFile/TestCleaner.java still fails with "cleaner failed to clean zipfile." #23742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…aner failed to clean zipfile."
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 41 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Not a review, just a drive-by comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jai,
I think the changes look ok overall. Thank you for tackling this one.
If we end up with such a facility, perhaps |
Thank you Lance for the review. I'll go ahead and integrate this now. For any new utility method, if it gets introduced in the Cleaner, like Brent notes we can rework the implementation of this test util at that time. |
/integrate |
Going to push as commit 3626ac3.
Your commit was automatically rebased without conflicts. |
Can I please get a review of this test-only change which proposes to address an intermittent failure in the
test/jdk/java/util/zip/ZipFile/TestCleaner.java
test?This test does operations on Inflater/Deflater/ZipFile and closes those instances and then waits for GC to kick in. After wait for a second, it then checks that the underlying resources held by these instances have been cleaned (by the Cleaner).
Once in a while, we have noticed that this test fails because the resources haven't been cleaned. I suspect this is because within the (fixed) 1 second wait time, the Cleaner hasn't yet invoked the cleaning action for these instances.
The commit in this PR updates the test to run it in
othervm
so that the Cleaner actions aren't delayed by any other test or code that might have previously run on theagentvm
. Furthermore, the test is also updated to the use theForceGC
test util which takes into account the jtreg test timeout factor for deciding how long to wait for the Cleaner to initiate the cleaning action. Our CI is configured with a timeout factor of 4, so with this change, instead of a fixed maximum 1 second wait time, the test will now wait a maximum of 4 seconds for the cleaner action to be invoked.The test continues to pass with this change, even with a repeat execution of 50 runs.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23742/head:pull/23742
$ git checkout pull/23742
Update a local copy of the PR:
$ git checkout pull/23742
$ git pull https://git.openjdk.org/jdk.git pull/23742/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23742
View PR using the GUI difftool:
$ git pr show -t 23742
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23742.diff
Using Webrev
Link to Webrev Comment