Skip to content

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 1, 2025

Hi all,
Several JMH tests fails "Unrecognized VM option 'UseAVX=2'" on linux-aarch64. The VM option '-XX:UseAVX=2' only support on x86_64 platform. This PR add option '-XX:+IgnoreUnrecognizedVMOptions' to make test run normally on non x86_64 platform.
Change has been verified locally, test-fix only, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349184: [JMH] jdk.incubator.vector.ColumnFilterBenchmark.filterDoubleColumn fails on linux-aarch64 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23409/head:pull/23409
$ git checkout pull/23409

Update a local copy of the PR:
$ git checkout pull/23409
$ git pull https://git.openjdk.org/jdk.git pull/23409/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23409

View PR using the GUI difftool:
$ git pr show -t 23409

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23409.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 1, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349184: [JMH] jdk.incubator.vector.ColumnFilterBenchmark.filterDoubleColumn fails on linux-aarch64

Reviewed-by: haosun, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 9aa6d09: 8326485: Assertion due to Type.addMetadata adding annotations to already-annotated type
  • 2cce5ee: 8349142: [JMH] compiler.MergeLoadBench.getCharBV fails
  • 305bbda: 8348402: PerfDataManager stalls shutdown for 1ms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 1, 2025
@openjdk
Copy link

openjdk bot commented Feb 1, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 1, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 3, 2025
@sendaoYan
Copy link
Member Author

Thanks all for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 3, 2025

Going to push as commit a57c9b1.
Since your change was applied there have been 6 commits pushed to the master branch:

  • d330421: 8337548: Parallel class loading can pass is_superclass true for interfaces
  • 3f1d9b5: 8348575: SpinLockT is typedef'ed but unused
  • 6f4fc82: 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland
  • 9aa6d09: 8326485: Assertion due to Type.addMetadata adding annotations to already-annotated type
  • 2cce5ee: 8349142: [JMH] compiler.MergeLoadBench.getCharBV fails
  • 305bbda: 8348402: PerfDataManager stalls shutdown for 1ms

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 3, 2025
@openjdk openjdk bot closed this Feb 3, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 3, 2025
@openjdk
Copy link

openjdk bot commented Feb 3, 2025

@sendaoYan Pushed as commit a57c9b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8349184 branch February 3, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants