Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342653: Fix minor doc issues in AnnotatedElement #21597

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Oct 20, 2024

Fix typo and remove redundant @since tags.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8342653: Fix minor doc issues in AnnotatedElement (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21597/head:pull/21597
$ git checkout pull/21597

Update a local copy of the PR:
$ git checkout pull/21597
$ git pull https://git.openjdk.org/jdk.git pull/21597/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21597

View PR using the GUI difftool:
$ git pr show -t 21597

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21597.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2024

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 20, 2024

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342653: Fix minor doc issues in AnnotatedElement

Reviewed-by: jpai, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 76ae072: 8342579: RISC-V: C2: Cleanup effect of killing flag register for call instructs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8342653: Fix minor doc issues in AnnotatedElement 8342653: Fix minor doc issues in AnnotatedElement Oct 20, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2024
@openjdk
Copy link

openjdk bot commented Oct 20, 2024

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 20, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2024

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me. The class itself is commented with @since 1.5, so removing it from methods which were introduced in the same release looks correct.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants