8342508: Use latch in BasicMenuUI/bug4983388.java instead of delay

[aivanov-jdk]

Use a CountDownLatch in javax/swing/plaf/basic/BasicMenuUI/4983388/bug4983388.java instead of delay.

The latch provides a direct way to synchronise EDT and main thread, the test will finish quicker.

I ran the updated test a few times with JTREG=REPEAT_COUNT=20, the test always passed in the CI.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342508: Use latch in BasicMenuUI/bug4983388.java instead of delay (Bug - P5)

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• @abdelhak-zaaim (no known openjdk.org user name / role)
• Alexander Zvegintsev (@azvegint - Reviewer)
• Abhishek Kumar (@kumarabhi006 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21585/head:pull/21585
$ git checkout pull/21585

Update a local copy of the PR:
$ git checkout pull/21585
$ git pull https://git.openjdk.org/jdk.git pull/21585/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21585

View PR using the GUI difftool:
$ git pr show -t 21585

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21585.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342508: Use latch in BasicMenuUI/bug4983388.java instead of delay

Reviewed-by: serb, azvegint, abhiscxk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• 239d84a: 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing
• aa060f2: 8342334: CDS: Scratch mirrors should not point to dead klasses
• 680dc5d: 8342496: C2/Shenandoah: SEGV in compiled code when running jcstress
• 8f2b23b: 8341407: C2: assert(main_limit == cl->limit() || get_ctrl(main_limit) == new_limit_ctrl) failed: wrong control for added limit
• 21682bc: 8342612: Increase memory usage of compiler/c2/TestScalarReplacementMaxLiveNodes.java
• d61f56a: 8342287: C2 fails with "assert(is_IfTrue()) failed: invalid node class: IfFalse" due to Template Assertion Predicate with two UCTs
• 76ae072: 8342579: RISC-V: C2: Cleanup effect of killing flag register for call instructs
• 309b929: 8336401: Remove the option onjcmd from the jdwp agent
• 401d0d6: 8335662: [AArch64] C1: guarantee(val < (1ULL << nbits)) failed: Field too big for insn
• 8591109: 8340698: JVMTI FRAME_POP event is sometimes missed if NotifyFramePop is called as a method is returning
• ... and 27 more: https://git.openjdk.org/jdk/compare/3ebfc6c1e27119180700af5ea85e5fa6c1771050...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@aivanov-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (10b51b09)

[kumarabhi006]

Looks ok to me except for a suggestion.

[kumarabhi006]

createAndShowGUI method is static, I suggest using method reference.