Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342609: jpackage test helper function incorrectly removes a directory instead of its contents only #21582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Oct 18, 2024

Files.walk(root, 0) returns the root itself and not the contents of the root.
Replaced Files.walk(root, 0) with Files.list(root) to get a non-recursive listing of the root directory.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only

Issue

  • JDK-8342609: jpackage test helper function incorrectly removes a directory instead of its contents only (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21582/head:pull/21582
$ git checkout pull/21582

Update a local copy of the PR:
$ git checkout pull/21582
$ git pull https://git.openjdk.org/jdk.git pull/21582/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21582

View PR using the GUI difftool:
$ git pr show -t 21582

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21582.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2024

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 18, 2024
@openjdk
Copy link

openjdk bot commented Oct 18, 2024

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 18, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2024

Webrevs

@sashamatveev
Copy link
Member

Looks good, but can you make issue title more descriptive of the issue.

@alexeysemenyukoracle alexeysemenyukoracle changed the title 8342609: Bug in jpackage test helper 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants