8342609: jpackage test helper function incorrectly removes a directory instead of its contents only #21582
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files.walk(root, 0)
returns theroot
itself and not the contents of theroot
.Replaced
Files.walk(root, 0)
withFiles.list(root)
to get a non-recursive listing of theroot
directory.Progress
Warning
8342609: jpackage test helper function incorrectly removes a directory instead of its contents only
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21582/head:pull/21582
$ git checkout pull/21582
Update a local copy of the PR:
$ git checkout pull/21582
$ git pull https://git.openjdk.org/jdk.git pull/21582/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21582
View PR using the GUI difftool:
$ git pr show -t 21582
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21582.diff
Webrev
Link to Webrev Comment