Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342588: Shenandoah: Pull shared closures together in one header #21579

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 18, 2024

Currently we have shenandoahClosures.hpp and shenandoahOopClosures.hpp, each of which have some closure inside. There is no reason to have this separation, and we should really just merge everything in one header. I also did a bit of mechanical renames. There should be no semantic change with this patch.

Additional testing:

  • Linux x86_64 server fastdebug, hotspot_gc_shenandoah

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8342588: Shenandoah: Pull shared closures together in one header (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21579/head:pull/21579
$ git checkout pull/21579

Update a local copy of the PR:
$ git checkout pull/21579
$ git pull https://git.openjdk.org/jdk.git pull/21579/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21579

View PR using the GUI difftool:
$ git pr show -t 21579

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21579.diff

Webrev

Link to Webrev Comment

@shipilev shipilev marked this pull request as ready for review October 18, 2024 09:14
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 18, 2024
@openjdk
Copy link

openjdk bot commented Oct 18, 2024

@shipilev The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Oct 18, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant