8340554: Improve MessageFormat readObject checks #21570
Open
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back jlu! A progress list of the required criteria for merging this PR into |
|
@justin-curtis-lu This change is no longer ready for integration - check the PR body for details. |
|
@justin-curtis-lu The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
naotoj
approved these changes
Oct 18, 2024
| // Offset equal to pattern length (variation) | ||
| new MessageFormat("X{0}"), | ||
| // Offset 1 under pattern length (variation) | ||
| new MessageFormat("X{0}X") |
There was a problem hiding this comment.
Nit: "(variation)" may not be needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this PR which improves the readObject logic for j.text.MessageFormat.
No offset should be larger than the pattern length. We already ensure the offsets when consumed backwards are equal/descending. The existing first/initial check was off by 1 since it was checking against the pattern length + 1; (see L2040 and L2043).
Please see the JBS issue for further info and other test details.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21570/head:pull/21570$ git checkout pull/21570Update a local copy of the PR:
$ git checkout pull/21570$ git pull https://git.openjdk.org/jdk.git pull/21570/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21570View PR using the GUI difftool:
$ git pr show -t 21570Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21570.diff
Webrev
Link to Webrev Comment