8341176: Permit access to diagnostics for transient snippets #21261
+91
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JShell permits to create transient snippets using
SourceCodeAnalysis.sourceToSnippets
, for the purpose of alternative UI clients. But, the alternative UI clients might need to get the diagnostics for the snippets, but the existingJShell.diagnostics(Snippet)
will not work for the transient snippets.This patch proposes to enhance the
JShell.diagnostics(Snippet)
with an ability to return best-effort diagnostics for these transient snippets.Please also review the CSR:
https://bugs.openjdk.org/browse/JDK-8341200
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21261/head:pull/21261
$ git checkout pull/21261
Update a local copy of the PR:
$ git checkout pull/21261
$ git pull https://git.openjdk.org/jdk.git pull/21261/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21261
View PR using the GUI difftool:
$ git pr show -t 21261
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21261.diff
Webrev
Link to Webrev Comment