-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8261513: Various BasicConstraintsExtension issues #20224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…epresentation for unconstrained pathLens
|
👋 Welcome back blperez01! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@blperez01 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
@blperez01 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@blperez01 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
|
/open |
|
@blperez01 This pull request is now open |
|
Re-opening PR |
src/java.base/share/classes/sun/security/x509/BasicConstraintsExtension.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more comments. You'll need to add an appropriate noreg label to the bug if you think it isn't practical to write a test for this.
src/java.base/share/classes/sun/security/x509/BasicConstraintsExtension.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/sun/security/x509/BasicConstraintsExtension.java
Show resolved
Hide resolved
|
@blperez01 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@blperez01 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
|
/open |
|
@blperez01 This pull request is now open |
Progress
Error
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20224/head:pull/20224$ git checkout pull/20224Update a local copy of the PR:
$ git checkout pull/20224$ git pull https://git.openjdk.org/jdk.git pull/20224/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20224View PR using the GUI difftool:
$ git pr show -t 20224Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20224.diff
Using Webrev
Link to Webrev Comment