Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250659: Clarify in ParameterizedType.getRawType() doc that only Class is returned #19978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liach
Copy link
Member

@liach liach commented Jul 1, 2024

Clarify that only Class is returned for core reflection implementation, and the return type is Type to support other implementations, such as ones modeling unloaded or remote types.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8335473 to be approved

Issues

  • JDK-8250659: Clarify in ParameterizedType.getRawType() doc that only Class is returned (Enhancement - P4)
  • JDK-8335473: Clarify in ParameterizedType.getRawType() doc that only Class is returned (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19978/head:pull/19978
$ git checkout pull/19978

Update a local copy of the PR:
$ git checkout pull/19978
$ git pull https://git.openjdk.org/jdk.git pull/19978/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19978

View PR using the GUI difftool:
$ git pr show -t 19978

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19978.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2024

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 1, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jul 1, 2024
@openjdk
Copy link

openjdk bot commented Jul 1, 2024

@liach The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 1, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 1, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2024

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@liach
Copy link
Member Author

liach commented Jul 29, 2024

Keep-alive.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 27, 2024

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2024

@liach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Sep 24, 2024
@liach
Copy link
Member Author

liach commented Sep 24, 2024

/open

@openjdk openjdk bot reopened this Sep 24, 2024
@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@liach This pull request is now open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant