Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8330095: RISC-V: Remove obsolete vandn_vi instruction #18737

Closed
wants to merge 1 commit into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Apr 11, 2024

Hi, We notice that the vandn_vi instruction is defined in the current code and is not used anywhere, it is not available in the riscv-crypto Release-1.0.0 manual. The vandn_vi instruction is present in earlier riscv-crypto manual, but the vandnvi has been removed from the riscv/riscv-crypto@82a02f0 commit.

Testing

  • fastdebug build successfully

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8330095: RISC-V: Remove obsolete vandn_vi instruction (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18737/head:pull/18737
$ git checkout pull/18737

Update a local copy of the PR:
$ git checkout pull/18737
$ git pull https://git.openjdk.org/jdk.git pull/18737/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18737

View PR using the GUI difftool:
$ git pr show -t 18737

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18737.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2024

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 11, 2024

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330095: RISC-V: Remove obsolete vandn_vi instruction

Reviewed-by: fyang, luhenry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • aebfd53: 8329660: G1: Improve TestGCLogMessages to be more precise
  • 006a516: 8329962: Remove CardTable::invalidate
  • c7fcd62: 8330006: Serial: Extract out ContiguousSpace::block_start_const
  • 2c8b432: 8330003: Serial: Move the logic of FastEvacuateFollowersClosure to SerialHeap
  • 2c45eca: 8328879: G1: Some gtests modify global state crashing the JVM during GC after JDK-8289822
  • bde3fc0: 8330106: C2: VectorInsertNode::make() shouldn't call ConINode::make() directly
  • e45fea5: 8329757: Crash with fatal error: DEBUG MESSAGE: Fast Unlock lock on stack
  • ece7d43: 8329416: Split relocation pointer map into read-write and read-only maps
  • 0db4290: 8330049: Remove unused AbstractLinker::linkerByteOrder
  • 5808f30: 8330026: Serial: Move some includes to vmStructs_serial.hpp
  • ... and 13 more: https://git.openjdk.org/jdk/compare/b04b3047ff5c5526bdf47925210e2a35ca191e6e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @luhenry) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 11, 2024
@openjdk
Copy link

openjdk bot commented Apr 11, 2024

@zifeihan The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 11, 2024
@zifeihan
Copy link
Member Author

@robehn Could you please take a look?

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 11, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 11, 2024

Webrevs

@zifeihan
Copy link
Member Author

@RealFYang @luhenry : Thanks for the review.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 12, 2024
@openjdk
Copy link

openjdk bot commented Apr 12, 2024

@zifeihan
Your change (at version 7b8fa23) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 12, 2024

Going to push as commit 77a217d.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 717a07b: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel
  • aebfd53: 8329660: G1: Improve TestGCLogMessages to be more precise
  • 006a516: 8329962: Remove CardTable::invalidate
  • c7fcd62: 8330006: Serial: Extract out ContiguousSpace::block_start_const
  • 2c8b432: 8330003: Serial: Move the logic of FastEvacuateFollowersClosure to SerialHeap
  • 2c45eca: 8328879: G1: Some gtests modify global state crashing the JVM during GC after JDK-8289822
  • bde3fc0: 8330106: C2: VectorInsertNode::make() shouldn't call ConINode::make() directly
  • e45fea5: 8329757: Crash with fatal error: DEBUG MESSAGE: Fast Unlock lock on stack
  • ece7d43: 8329416: Split relocation pointer map into read-write and read-only maps
  • 0db4290: 8330049: Remove unused AbstractLinker::linkerByteOrder
  • ... and 14 more: https://git.openjdk.org/jdk/compare/b04b3047ff5c5526bdf47925210e2a35ca191e6e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 12, 2024
@openjdk openjdk bot closed this Apr 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 12, 2024
@openjdk
Copy link

openjdk bot commented Apr 12, 2024

@RealFYang @zifeihan Pushed as commit 77a217d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zifeihan zifeihan deleted the JDK-8330095 branch June 19, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants