4622866: javax.swing.text.Document.remove(int, int) has a misleading picture #15701
Conversation
…picture Update the image demonstrating the removal of text from a document. Use SVG for the new image.
This avoids antialiasing and makes the edges crisp and sharp.
I think it refers to document as the entity, not to the class/interface.
|
👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into |
|
@aivanov-jdk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
Perhaps, the intention of the original image was to demonstrate that all the marks in the range 4–10 are collapsed to 4. That is the mark at offset 6 is at offset 4 after the removal: The above image could still be confusing. |
The 'shape-rendering: crispEdges' did give crisp edges in 100% scale, but in 200% scale some edges are 3-pixel wide and others are 2-pixel. Using 0.5 pixel offset solves both problems. I verified rendering on 100%-scale display as well as on 150%- and 200%-scale displays.
|
@aivanov-jdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 128 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 73a47f0.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
|
@aivanov-jdk Pushed as commit 73a47f0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The image in the documentation for
Document.removelooks as if the portion between the offsets 6 and 10 is removed. However, the entire region for ‘quick ’ is highlighted.I updated the image to mark the start offset 4 and the end offset 10. The new image is in SVG format which looks crisp on modern High DPI displays.
I added a sentence that describes the image, which makes the documentation accessible and clearer.
Also, I marked up references to classes and members with
{@code}.Look at the updated version:
Document.removein JDK 22.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15701/head:pull/15701$ git checkout pull/15701Update a local copy of the PR:
$ git checkout pull/15701$ git pull https://git.openjdk.org/jdk.git pull/15701/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15701View PR using the GUI difftool:
$ git pr show -t 15701Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15701.diff
Webrev
Link to Webrev Comment