8315863: [GHA] Update checkout action to use v4

[sormuras]

Please review this change to update all workflows to use actions/checkout@v4.

Find the associated release notes here: https://github.com/actions/checkout/releases/tag/v4.0.0

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315863: [GHA] Update checkout action to use v4 (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15620/head:pull/15620
$ git checkout pull/15620

Update a local copy of the PR:
$ git checkout pull/15620
$ git pull https://git.openjdk.org/jdk.git pull/15620/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15620

View PR using the GUI difftool:
$ git pr show -t 15620

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15620.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sormuras The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (dd2bc925)

[shipilev]

I guess we can do this, but does it fix any actual bug or gives us improvements we can use?

[sormuras]

Mainly because the underlying Node version used by actions/checkout@v3 will reach EOL soon:

Copied from actions/checkout#1436

Node12 was deleted from runner. Node20 was added to Actions Runner on v2.308.0.
Node16 has en end of life on 11 Sep 2023.

[shipilev]

Oh, okay then!

[openjdk]

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315863: [GHA] Update checkout action to use v4

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 8f7e29b: 8313422: test/langtools/tools/javac 144 test classes uses com.sun.tools.classfile library
• 8557205: 8312569: RISC-V: Missing intrinsics for Math.ceil, floor, rint
• 2fd870a: 8315444: Convert test/jdk/tools to Classfile API

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sormuras]

/integrate

[openjdk]

Going to push as commit b74805d.
Since your change was applied there have been 4 commits pushed to the master branch:

• 1cae0f5: 8315220: Event NativeLibraryLoad breaks invariant by taking a stacktrace when thread is in state _thread_in_native
• 8f7e29b: 8313422: test/langtools/tools/javac 144 test classes uses com.sun.tools.classfile library
• 8557205: 8312569: RISC-V: Missing intrinsics for Math.ceil, floor, rint
• 2fd870a: 8315444: Convert test/jdk/tools to Classfile API

Your commit was automatically rebased without conflicts.

[shipilev]

Please wait for GHA to complete before integrating GHA patches!

[openjdk]

@sormuras Pushed as commit b74805d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sormuras]

Please wait for GHA to complete before integrating GHA patches!

Yes, sure. Next time, I'll wait for completion - this time, I checked that actions/checkout@v4 steps were successfully run in https://github.com/openjdk/jdk/pull/15620/checks

[shipilev]

Please wait for GHA to complete before integrating GHA patches!

Yes, sure. Next time, I'll wait for completion - this time, I checked that actions/checkout@v4 steps were successfully run in https://github.com/openjdk/jdk/pull/15620/checks

Yeah, the problem with some GH action steps is that they have "epilog" steps that run at the end of the pipe. So when changing GH action stuff, it is important to see that all steps have completed, which usually means the complete run.