8314544: Matrix multiply benchmark using Vector API #15338

Styp · 2023-08-18T03:57:24Z

Added a bunch of different implementations for Vector API Matrix Multiplications:

Baseline
Blocked (Cache Local)
FMA
Vector API Simple Implementation
Vector API Blocked Implementation

Commit was discussed with @PaulSandoz

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8314544: Matrix multiply benchmark using Vector API (Bug - P4)

Reviewers

Paul Sandoz (@PaulSandoz - Reviewer)
Eric Liu (@e1iu - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15338/head:pull/15338
$ git checkout pull/15338

Update a local copy of the PR:
$ git checkout pull/15338
$ git pull https://git.openjdk.org/jdk.git pull/15338/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15338

View PR using the GUI difftool:
$ git pr show -t 15338

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15338.diff

Webrev

Link to Webrev Comment

Rebase from upstream

bridgekeeper · 2023-08-18T03:58:26Z

👋 Welcome back Styp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-08-18T03:59:23Z

@Styp The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-08-18T04:03:48Z

Webrevs

01: Full - Incremental (5bda0c2e)
00: Full (c5289fdc)

PaulSandoz · 2023-08-18T20:09:10Z

test/micro/org/openjdk/bench/jdk/incubator/vector/MatrixMultiplicationBenchmark.java

+    }
+
+    private static float[] newFloatRowMatrix(int size) {
+        Random rand = new Random();


Instead we can use the new random generator API e.g,:

var rand = RandomGenerator.getDefault();

This is not super important, but its good practice to try and use more preferred APIs.

PaulSandoz · 2023-08-18T20:09:15Z

test/micro/org/openjdk/bench/jdk/incubator/vector/MatrixMultiplicationBenchmark.java

+import java.util.concurrent.TimeUnit;
+
+import org.openjdk.jmh.annotations.*;
+import org.openjdk.jmh.infra.Blackhole;


Unused import.

Styp · 2023-08-21T03:50:32Z

Changed according to comments.

e1iu

Looks good to me.

sviswa7 · 2023-10-03T23:13:43Z

@Styp Please correct the title in the PR. There is title mismatch between PR and JBS.
PR title: Matrix multiple benchmark using Vector API
"multiple" vs "multiply"

Styp · 2023-10-06T08:32:28Z

fixed typo.

openjdk · 2023-10-06T08:59:12Z

@Styp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314544: Matrix multiply benchmark using Vector API

Reviewed-by: psandoz, eliu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1495 new commits pushed to the master branch:

519ecd3: 8319413: Start of release updates for JDK 23
86f9b3f: 8319313: G1: Rename G1EvacFailureInjector appropriately
a7f6016: 8320370: NMT: Change MallocMemorySnapshot to simplify code.
58530f4: 8321223: Implementation of Scoped Values (Second Preview)
2f9e70e: 8321001: RISC-V: C2 SignumVF
de95259: 8316454: JFR break locale settings
c42535f: 8321470: ThreadLocal.nextHashCode can be static final
42bb852: 8321467: MemorySegment.setString(long, String, Charset) throws IAE(Misaligned access)
c087e91: 8321505: JFR: Update views
ead4fb1: 8321519: Typo in exception message
... and 1485 more: https://git.openjdk.org/jdk/compare/b78f5a1068224d8b3cfe9e8fb38307ca07de741d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@PaulSandoz, @e1iu) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

sviswa7 · 2023-10-06T16:09:56Z

@Styp Thanks, the next step would be for you to flag this PR as ready for integration by typing /integrate in a new github comment and submit. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

bridgekeeper · 2023-11-03T18:39:30Z

@Styp This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2024-01-04T18:57:11Z

@Styp This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

Styp added 3 commits August 17, 2023 09:05

Merge pull request #1 from openjdk/master

09a0471

Rebase from upstream

added MatrixMultiplicationBenchmark

3f4f129

fixed some style issues

c5289fd

openjdk bot added the rfr Pull request is ready for review label Aug 18, 2023

openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 18, 2023

PaulSandoz reviewed Aug 18, 2023

View reviewed changes

Styp added 2 commits August 21, 2023 05:47

improved some RandomGenerator & unuseed Imports

f91b5a8

changed for consistency

5bda0c2

PaulSandoz approved these changes Aug 23, 2023

View reviewed changes

e1iu approved these changes Sep 8, 2023

View reviewed changes

Styp changed the title ~~8314544: Matrix multiple benchmark using Vector API~~ 8314544: Matrix multiply benchmark using Vector API Oct 6, 2023

openjdk bot added the ready Pull request is ready to be integrated label Oct 6, 2023

bridgekeeper bot closed this Jan 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8314544: Matrix multiply benchmark using Vector API #15338

8314544: Matrix multiply benchmark using Vector API #15338

Uh oh!

Styp commented Aug 18, 2023 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Aug 18, 2023

Uh oh!

openjdk bot commented Aug 18, 2023

Uh oh!

mlbridge bot commented Aug 18, 2023 •

edited

Loading

Uh oh!

PaulSandoz Aug 18, 2023

Uh oh!

PaulSandoz Aug 18, 2023

Uh oh!

Styp commented Aug 21, 2023

Uh oh!

e1iu left a comment

Uh oh!

sviswa7 commented Oct 3, 2023

Uh oh!

Styp commented Oct 6, 2023

Uh oh!

openjdk bot commented Oct 6, 2023 •

edited

Loading

Uh oh!

sviswa7 commented Oct 6, 2023

Uh oh!

bridgekeeper bot commented Nov 3, 2023

Uh oh!

bridgekeeper bot commented Jan 4, 2024

Uh oh!

Uh oh!

8314544: Matrix multiply benchmark using Vector API #15338

8314544: Matrix multiply benchmark using Vector API #15338

Uh oh!

Conversation

Styp commented Aug 18, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Aug 18, 2023

Uh oh!

openjdk bot commented Aug 18, 2023

Uh oh!

mlbridge bot commented Aug 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

PaulSandoz Aug 18, 2023

Choose a reason for hiding this comment

Uh oh!

PaulSandoz Aug 18, 2023

Choose a reason for hiding this comment

Uh oh!

Styp commented Aug 21, 2023

Uh oh!

e1iu left a comment

Choose a reason for hiding this comment

Uh oh!

sviswa7 commented Oct 3, 2023

Uh oh!

Styp commented Oct 6, 2023

Uh oh!

openjdk bot commented Oct 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sviswa7 commented Oct 6, 2023

Uh oh!

bridgekeeper bot commented Nov 3, 2023

Uh oh!

bridgekeeper bot commented Jan 4, 2024

Uh oh!

Uh oh!

Styp commented Aug 18, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Aug 18, 2023 •

edited

Loading

openjdk bot commented Oct 6, 2023 •

edited

Loading