JDK-8368907: Fix WindowsException allow ERROR_PRIVILEGE_NOT_HELD(1314) be converted to AccessDeniedException #15221
Conversation
…d to AccessDeniedException
|
Hi @iseki0, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user iseki0" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
@iseki0 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
I'm waiting OCA review. 😳 |
|
/signed |
|
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
@iseki0 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
What's happened? The OCA is under reviewing for a long time. |
|
@iseki0 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@iseki0 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
|
/open |
|
@iseki0 This pull request is now open |
|
@iseki0 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
I want to know. What're the OCA reviewers doing? 😁 |
|
@iseki0 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@iseki0 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
|
/reopen ? |
|
/open |
|
@iseki0 Unknown command |
|
❗ This change is not yet ready to be integrated. |
|
@iseki0 This pull request is now open |
|
2 problems:
|
@aivanov-jdk Could you help me solve the problems? Thank you. |
@iseki0 You can submit a bug using https://bugreport.java.com. You can also discuss this kind of issues at the core-libs-dev mailing list. People on the mailing list could also help you create an issue in JBS. A pull request won't be announced on the relevant mailing list until it's linked to a JBS issue. |
|
@iseki0 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
3 similar comments
|
@iseki0 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@iseki0 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@iseki0 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@iseki0 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
iseki0
changed the title
|
/open Now it's related to JDK-8368907 |
|
/open |
|
@iseki0 This pull request is now open |
|
@iseki0 This pull request is already open |
|
The message FileSystemException is difference between different Windows locale settings. In zh-Hans-CN:
You can see I have no way to determine what happened actually, without a pattern matching on the message. And since the message is various during different locale, it's almost impossible. |
|
@iseki0 this pull request can not be integrated into git checkout master-1
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
openjdk
bot
added
the
merge-conflict
|
Fixed by #27753 |
2 participants
Fix WindowsException allow ERROR_PRIVILEGE_NOT_HELD(1314) be converted to AccessDeniedException
JDK-8368907
Progress
Errors
Integration blocker
Warnings
...
Issue
Backport <hash>with the hash of the original commit. See Backports.Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15221/head:pull/15221$ git checkout pull/15221Update a local copy of the PR:
$ git checkout pull/15221$ git pull https://git.openjdk.org/jdk.git pull/15221/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15221View PR using the GUI difftool:
$ git pr show -t 15221Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15221.diff