Skip to content

Check the GPU architecture before Tile compilation - #1199

Open
xyyNicole wants to merge 1 commit into
openjdk:code-reflectionfrom
xyyNicole:tile-arch-check
Open

xyyNicole wants to merge 1 commit into
openjdk:code-reflectionfrom
xyyNicole:tile-arch-check

Conversation

@xyyNicole

@xyyNicole xyyNicole commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

HAT compiles generated CUDA source with nvcc or NVRTC. Tile code generation starts at sm_80. Both compilers now read the device compute capability in one place and reject Tile compilation on older GPUs before the compiler runs. The generated CUDA source is saved first, and the error names that file.



Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/1199/head:pull/1199
$ git checkout pull/1199

Update a local copy of the PR:
$ git checkout pull/1199
$ git pull https://git.openjdk.org/babylon.git pull/1199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1199

View PR using the GUI difftool:
$ git pr show -t 1199

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/1199.diff

Using Webrev

Link to Webrev Comment

HAT compiles generated CUDA source with nvcc or NVRTC. Tile code
generation starts at sm_80. Both compilers now read the device compute
capability in one place and reject Tile compilation on older GPUs before
the compiler runs. The generated CUDA source is saved first, and the
error names that file.
@bridgekeeper

bridgekeeper Bot commented Sep 29, 2026

Copy link
Copy Markdown

👋 Welcome back xyyNicole! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

@xyyNicole This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Check the GPU architecture before Tile compilation

You can use pull request commands such as /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the code-reflection branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 29, 2026
@mlbridge

mlbridge Bot commented Sep 29, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant