-
Notifications
You must be signed in to change notification settings - Fork 8
Refactor component and add additional features #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
IoannisLafiotis
merged 79 commits into
openintegrationhub:master
from
blendededge:master
Dec 7, 2021
Merged
Refactor component and add additional features #7
IoannisLafiotis
merged 79 commits into
openintegrationhub:master
from
blendededge:master
Dec 7, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sform and ability to apply transform to response body and save to the snapshot. This can be used for paging. Converted to new OIH message format and to actually work with axios config and response. Fixed all unit tests. Fixed form data submissions. Added url transform back in. Fixed linting errors. Still one failing test for attachment processing which is missing/removed.
…g auth configuration. Commented out attachments unit test temporarily until functionality added back in. Changed test log level to fatal to avoid logging during build tests
…re in progress. I'm going to create a version without the attachment functionality fully done.
Feature/paging
Bumps [yarn](https://github.com/yarnpkg/yarn) from 1.7.0 to 1.22.0. - [Release notes](https://github.com/yarnpkg/yarn/releases) - [Changelog](https://github.com/yarnpkg/yarn/blob/master/CHANGELOG.md) - [Commits](yarnpkg/yarn@v1.7.0...v1.22.0) --- updated-dependencies: - dependency-name: yarn dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
….22.0 Bump yarn from 1.7.0 to 1.22.0
Feature/error update
…d to the emitted message on error
Feature/fix linting
…st and requeue it to the component after that delay period has passed.
Added jsonataResponseValidator configuration to rebound/delay a reque…
…In our case we want to add the 404 status code to keep checking until a REST resource exists.
Added ability to configure which error status codes cause a rebound. …
Fixed the output for the error message
…o iterate the logic
…point where tests still work
Update utils.js. Whitespace deployment
…e in workflow yaml
Switch docker build from npm to yarn to reflect lock file, fixed issu…
… to pull in the latest version of ferryman
Reverted changes to master.yml to see if that caused the docker image…
Removed build cache to fix wrong ferryman library somehow being included
…n 1.7 has breaking changes
Switched ferryman version definition from caret to tilde since versio…
Reversed disabling cache since it wasn't the root cause of the ferryman issue
Update master.yml
Updating version number for next release
Updated ferryman version to the latest
Ferryman latest patch 1
…any pre-release tags and will also make the package.json version match the git tag version using the npm version command
Created separate GitHub Action workflow for tags. It will now ignore …
Added snapshot to process method
Feature/ferryman versions
SvenHoeffler
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good number of fixes and enhancements. I currently see no issue adding them.
heggert
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Pagination
For the pagination we added two types with the thought to eventually support more.
The difference is that #1 allows a consistent flow of data and you can adjust the interval and page size. #2 allows a flow creator to better reason about how they are consuming data and allows closer to real-time syncing.
Right now we are supporting pagination that exists in the URL and in the body. As an example we are using pagination as a URL parameter and Shopify uses a cursor in the body of the GraphQL request