Skip to content

Add script to update german shool holidays #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KristjanESPERANTO
Copy link
Collaborator

I have problems with hc to update the shool holidays, so I wrote another script.

Side note: In the medium term, I would like to get PH and SH from the API of https://www.openholidaysapi.org, but I would only make the effort if PRs are accepted here again. I don't want to do the work for nothing.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • CHANGELOG.rst: Language not supported
Comments suppressed due to low confidence (1)

scripts/update_german_sh.mjs:38

  • [nitpick] The parameter 'intendDash' may be a misspelling of 'indentDash'. Renaming it would improve clarity.
function convertToYaml(data, intendDash) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants