Skip to content

Prettified value support long day/month name #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prettified value support long day/month name #473

wants to merge 2 commits into from

Conversation

paulbriton
Copy link

Added a user configuration to return full weekday and month name.

ypid
ypid requested changes Apr 5, 2025
View reviewed changes
Copy link
Member

@ypid ypid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Two minor things:

  • Can you update types/index.d.ts as well?
  • The Fix typo commit should be rebased into the "Prettified value support long day/month name" commit. git commit --amend is your friend to avoid that from the start.

@ypid ypid requested a review from KristjanESPERANTO April 5, 2025 10:01
KristjanESPERANTO
KristjanESPERANTO approved these changes Apr 6, 2025
View reviewed changes
Copy link
Collaborator

@KristjanESPERANTO KristjanESPERANTO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too. I have nothing to add to ypid's review 🙂

Prettified value support long day/month name
fc7172c 
Added a user configuration to return full  weekday and month name.

Fix typo

Temp commit to hold changes
@paulbriton
Copy link
Author

Hey, thanks a lot for your feedback. I've updated my branch to include the requested changes.

@paulbriton paulbriton requested a review from ypid April 7, 2025 08:13
HolgerJeromin
HolgerJeromin reviewed Apr 7, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HolgerJeromin HolgerJeromin HolgerJeromin approved these changes

@KristjanESPERANTO KristjanESPERANTO KristjanESPERANTO approved these changes

@ypid ypid Awaiting requested review from ypid

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulbriton @ypid @HolgerJeromin @KristjanESPERANTO