-
Notifications
You must be signed in to change notification settings - Fork 123
Changes for new release #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes for new release #468
Conversation
e62e98f
to
2d28f1c
Compare
@ypid: Before I go any further, can you please check if I'm going in the right direction here? My next step would be to review and (if ok) merge more PRs. |
f52edbf
to
9b1f4ba
Compare
I think it's more than enough for a release now. Let me know if you don't like anything. |
9b1f4ba
to
7368dc3
Compare
45cf661
to
c501c39
Compare
2f3ba59
to
2b93ce5
Compare
@KristjanESPERANTO Thanks very much for all your work! I am currently working on a private project in my spare time which should be completed by the Edit: I will work on this |
No problem, there's no hurry 🙂 |
If a rebase helps you to review it or anything else, let me know. |
- js-yaml' development seems to be dead (no release for years, many open PRs and issues) - yaml' is actively maintained and more modern (ESM)
c7698d6
to
044e2cb
Compare
As discussed in #341, I have collected changes for the next release here.
My goal for the next release is to take care of low-hanging fruits first. This mainly includes adopting existing easy-to-understand PRs, updating the toolchain a bit and fixing small flaws found along the way.
Major changes and handling reported issues I would plan for after the next release. Steps like these are what I would consider major changes:
I will leave comments on some of the commits here:
Merged PRs
Solved issues
Not merged PRs
🎆 Running CI with maintained node versions 82d534a
I had to update
husky
and reworkci.yml
for this.🐞 Fix 'yamlToJson.mjs' 2d28f1c
Side note: I don't know where the script is used. I noticed during the review that it uses prettier and that prettier is not in the package.json.
Nits
There are some nits like
Thoughts
After some work on this PR, I think it would have been clearer if I had written my additional changes in separate PRs and used this one as a collector for them.