update service-mesh site-values #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
|
This PR was closed because it has been stalled for 10 days with no activity. |
to sync with tks-custom-base
seungkyua
approved these changes
Jan 13, 2022
|
tks-cluster -> tks-cluster-aws 로 폴더명이 변경되었는데, 의도하신 변경인지요 |
네, 의도한 변경입니다. decapod-base (또는 tks-custom-base) 와 site 를 머지하는 과정에서 모든 app 간에 디렉토리 구조와 depth가 통일되어야겠더라구요 |
ktkfree
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/openinfradev/tks-issues/issues/76
hanu-reference template을 tks 쪽에서 함께 사용하기로 했으므로, service-mesh ingress 생성 부분을 false로 변경합니다.