Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature:update redis client #190

Merged
merged 4 commits into from
Sep 21, 2023
Merged

feature:update redis client #190

merged 4 commits into from
Sep 21, 2023

Conversation

lluckyboi
Copy link
Contributor

@lluckyboi lluckyboi commented Sep 20, 2023


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

improve the granularity of testing and future-proof the application against changes in third-party libraries or their versions.

🅰 Which issue(s) this PR fixes:

Fixes #182

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 20, 2023
@kubbot
Copy link
Contributor

kubbot commented Sep 20, 2023

CLA Assistant Lite bot 🤖 All Contributors have signed the openkf CLA.
The signed information is recorded 🤖here

@lluckyboi
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

openimbot added a commit to openim-sigs/cla that referenced this pull request Sep 20, 2023
@lluckyboi lluckyboi changed the title feature:update redis client(#182) feature:update redis client Sep 20, 2023
Copy link
Contributor

@charles-chenzz charles-chenzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the mock client should live under /test or something like this. it should not mix up with the real implement

@cubxxw
Copy link
Contributor

cubxxw commented Sep 20, 2023

@lluckyboi Use make lint to inspect your code

@kubbot
Copy link
Contributor

kubbot commented Sep 20, 2023

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@lluckyboi Use make lint to inspect your code

@IRONICBo
Copy link
Contributor

Please check the lint first.

@cubxxw
Copy link
Contributor

cubxxw commented Sep 21, 2023

I have read the CLA Document and I hereby sign the CLA

openimbot added a commit to openim-sigs/cla that referenced this pull request Sep 21, 2023
@lluckyboi
Copy link
Contributor Author

I think the mock client should live under /test or something like this. it should not mix up with the real implement

Okay, I've already done this

Copy link
Contributor

@cubxxw cubxxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cubxxw
Copy link
Contributor

cubxxw commented Sep 21, 2023

@a67793581 Could you review it ?

Copy link
Contributor

@charles-chenzz charles-chenzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@IRONICBo IRONICBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cubxxw cubxxw added this pull request to the merge queue Sep 21, 2023
@cubxxw
Copy link
Contributor

cubxxw commented Sep 21, 2023

/invite

Merged via the queue into openimsdk:main with commit dd730f7 Sep 21, 2023
@kubbot
Copy link
Contributor

kubbot commented Sep 21, 2023

We value close connections with our users, developers, and contributors here at Open-IM-Server. With a large community and maintainer team, we're always here to help and support you. Whether you're looking to join our community or have any questions or suggestions, we welcome you to get in touch with us.

Our most recommended way to get in touch is through Slack. Even if you're in China, Slack is usually not blocked by firewalls, making it an easy way to connect with us. Our Slack community is the ideal place to discuss and share ideas and suggestions with other users and developers of Open-IM-Server. You can ask technical questions, seek help, or share your experiences with other users of Open-IM-Server.

In addition to Slack, we also offer the following ways to get in touch:

  • We also have Slack channels for you to communicate and discuss. To join, visit https://slack.com/ and join our 👀 Open-IM-Server slack team channel.
  • Get in touch with us on Gmail. If you have any questions or issues that need resolving, or any suggestions and feedback for our open source projects, please feel free to contact us via email.
  • Read our blog. Our blog is a great place to stay up-to-date with Open-IM-Server projects and trends. On the blog, we share our latest developments, tech trends, and other interesting information.
  • Add Wechat and indicate that you are a user or developer of Open-IM-Server. We will process your request as soon as possible.

@kubbot
Copy link
Contributor

kubbot commented Sep 21, 2023

🤖 Auto-closing issue, if you still need help please reopen the issue or ask for help in the community above

@openimsdk openimsdk locked and limited conversation to collaborators Sep 21, 2023
@kubbot kubbot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing Unit Testing Through Interface-Based Redis/Mysql Client Design
5 participants