Skip to content

Conversation

@andreassolberg
Copy link
Contributor

Summary

Fix validation step 7 for Trust Mark Delegation to correctly handle the optional exp claim.

Problem

The exp claim is defined as OPTIONAL in the Trust Mark Delegation JWT claims (Section 7.2.1):

exp: OPTIONAL. Number. Time when this delegation stops being valid. [...] If not present, it means that the delegation does not expire.

However, validation step 7 unconditionally required checking the exp claim:

The current time MUST be before the time represented by the exp (expiration) Claim in the delegation...

This is inconsistent - if exp is optional and "delegation does not expire" when absent, then the validation should only apply when exp is present.

Changes

Make validation step 7 conditional:

<!-- Before -->
<t>The current time MUST be before the time represented by the exp (expiration) 
Claim in the delegation (possibly allowing for some small leeway to account 
for clock skew).</t>

<!-- After -->
<t>If the <spanx style="verb">exp</spanx> (expiration) Claim is present in 
the delegation, the current time MUST be before the time it represents 
(possibly allowing for some small leeway to account for clock skew).</t>

References

🤖 Generated with Claude Code

The exp claim is defined as OPTIONAL in the Trust Mark Delegation JWT
claims, with the note: "If not present, it means that the delegation
does not expire."

However, validation step 7 unconditionally required checking the exp
claim, which was inconsistent with its OPTIONAL status.

This change makes validation step 7 conditional on the presence of exp.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@selfissued
Copy link
Member

This fix also applies to OpenID Federation 1.0.

@rohe rohe self-requested a review January 8, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants