Conversation
|
📄 Editor's Copy preview Preview of a9ce0fc; updated on every push. For review only — the official specifications are published at https://openid.net/specs/ |
There was a problem hiding this comment.
We need to update the definition of 'allow_multiple' - it currently says "Allow returning multiple credentials of the same type" and my presumption is with this change you end up allowing any of the types in the array. (This falls out of it being semantically equivalent to the longer form non-array form of repeating the query.)
Note this will clash with #57 - we could use stacked PRs here: https://docs.github.com/en/pull-requests/how-tos/stacked-pull-requests (i.e. built on top of my branch, and assuming mine is merged first GitHub should auto retarget yours to main when mine is merged). The a query matches credentials whose docType or vct "is identical to the requested value" in mine will need to be updated too.
| | `encryption_ref` | `7` | `int` | O | Reference to an entry in `additional_encryption_contexts`; absent means the main `encryption_context` is used | | ||
|
|
||
| Listing multiple values in `credential_type` is a size optimization for requesting the same data elements from credential types that are closely related (e.g., newer versions of the same credential type). The same effect could be achieved by defining multiple `CredentialQuery` entries. | ||
| The verifier MUST ensure that every element in `elements_dict` is defined for each listed credential type. |
There was a problem hiding this comment.
Discussed on today's WG call:
Martijn will make a comment/suggestion. It's not a "MUST" but for the query to work this needs to be the case, e.g. if one credential has an extension and the other doesn't.
| | `format_extensions` | `6` | `formatExtensions` | O | Format-specific extensions (e.g., `mdocExtensions`, `sdjwtExtensions`) | | ||
| | `encryption_ref` | `7` | `int` | O | Reference to an entry in `additional_encryption_contexts`; absent means the main `encryption_context` is used | | ||
|
|
||
| Listing multiple values in `credential_type` is a size optimization for requesting the same data elements from credential types that are closely related (e.g., newer versions of the same credential type). The same effect could be achieved by defining multiple `CredentialQuery` entries. |
There was a problem hiding this comment.
See above
| Listing multiple values in `credential_type` is a size optimization for requesting the same data elements from credential types that are closely related (e.g., newer versions of the same credential type). The same effect could be achieved by defining multiple `CredentialQuery` entries. | |
| Listing multiple values in `credential_types` is a size optimization for requesting the same data elements from credential types that are closely related (e.g., newer versions of the same credential type). The same effect could be achieved by defining multiple `CredentialQuery` entries. |
Co-authored-by: Joseph Heenan <joseph@heenan.me.uk> Co-authored-by: Oliver Terbu <o.terbu@gmail.com>
|
Not sure what gh did from committing a 2 word change (via UI suggestions in gh) to creating a 1200 line commit that doesn't change anything but 2 words... I'll force push remove the last commit if this doesn't fix itself |
3b3211d to
a9ce0fc
Compare
This branch has not been deployed
3 participants
Closes #46