Add support for app2app on iOS #549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user has an app installed that has a Universal Link registered for the authorization endpoint, then launching that app will provide a better user experience. If the launch fails, we continue as before to use an in-app browser tab etc. See this OpenID Foundation blog post for further details: https://openid.net/2019/10/21/guest-blog-implementing-app-to-app-authorisation-in-oauth2-openid-connect/ There was a question about whether to make this the default behaviour or not; the documentation for OIDExternalUserAgentIOS says: > An iOS specific external user-agent that uses the best possible > user-agent available ... so I think it's consistent with the documented goal to enable app2app by default.
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
=======================================
Coverage 83.75% 83.75%
=======================================
Files 50 50
Lines 4617 4617
=======================================
Hits 3867 3867
Misses 750 750 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has an app installed that has a Universal Link registered
for the authorization endpoint, then launching that app will provide a
better user experience.
If the launch fails, we continue as before to use an in-app browser
tab etc.
See this OpenID Foundation blog post for further details:
https://openid.net/2019/10/21/guest-blog-implementing-app-to-app-authorisation-in-oauth2-openid-connect/
There was a question about whether to make this the default behaviour
or not; the documentation for OIDExternalUserAgentIOS says:
so I think it's consistent with the documented goal to enable app2app
by default.