Repository navigation
Conversation
added 13 commits
September 17, 2026 09:45
georgiatai
reviewed
Oct 8, 2026
georgiatai
left a comment
georgiatai
left a comment
Contributor
There was a problem hiding this comment.
some comments and reminder.
This file should be a module for a single lane in the VF execution unit
|
|
||
| logic [4:0] VfmaFlg; | ||
| logic [P.FLEN-1:0] VfmaRes; | ||
| postprocess #(P, 1) postproc ( |
Contributor
There was a problem hiding this comment.
compact the signals to about 80 characters per line
| input logic [2:0] OpCtrlM, | ||
| input logic [P.FMALEN-1:0] SmM, | ||
| input logic [P.NE+1:0] SeM, | ||
| input logic AsM, |
Contributor
There was a problem hiding this comment.
some of these can be merged into one line, e.g. AsM, PsM,SsM, and the inf/nan/snan above
| logic ZZero; | ||
|
|
||
| unpackinput #(P) unpackX ( | ||
| .A(X), .Fmt(FmaXFmt), .En(1'b1), .FPUActive, |
Contributor
There was a problem hiding this comment.
reminder that you would want 3 unpack in a lane. fma can take 3 operands
| output logic [P.NE+1:0] SeE, | ||
| output logic AsE, | ||
| output logic PsE, | ||
| output logic SsE, |
Contributor
There was a problem hiding this comment.
the final output should probably be a single EEW, post-processed element?
| //////////////////////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| module vfred import cvw::*; #(parameter cvw_t P) ( | ||
| input logic [P.FLEN-1:0] X, Z, // two operands |
Contributor
There was a problem hiding this comment.
These should probably be ELEN. refer to the block diagram
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vector reduction before testing