Repository navigation
Conversation
|
Thanks for the PR. You’ll need to sign an Eclipse Contributor Agreement indicating that you are licensing your contributions as open source. You need to create an account with https://www.eclipse.org/ Sign the agreement, https://www.eclipse.org/legal/ECA.php |
|
Suggested changes:
|
| if [[ "$FAMILY" = "fedora" ]] ; then | ||
| PYTHON_OPTION="--without-python" # Avoid problems when the python version is incorrect | ||
| else | ||
| PYTHON_OPTION="" | ||
| fi |
There was a problem hiding this comment.
What error is this causing? I'd rather fix the Python version instead of telling it to build without Python.
|
The error from the log is as follows: Note that despite not finding pyconfig.h, python is detected earlier in the process, with version 3.14 in /usr. My first idea was to fix it properly, possibly installing the correct Python version in the docker image or using a virtual env. However, I examined the output from another build configuration (e.g., OpenSuse) and I noticed that Python was not being detected there at all, hence I concluded that it is not really necessary to build the python support in boost. Since fixing this problem can be time consuming and there is no actual benefit, I chose the workaround. If you think that this is not acceptable, I will try another way. But currently I think that disabling python support in boost is the best way to proceed. |
|
I have checked and all other distros build boos without Python support, emitting the following warning:
In the case of Fedora, it detects Python 3.14 and then tries to build Python support, but fails. Maybe the right fix to keep the build as it is for all distros is to add --without-python unconditionally? |
This PR adds support for installing in Fedora in addition to the already supported distributions (Ubuntu, Debian, SUSE and Red Hat). Only minimal changes are required.