Skip to content

Conversation

@holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich commented Aug 24, 2025

Upgrade checkstyle from 10.26.1 to 11.0.1

Changlog:
https://github.com/checkstyle/checkstyle/releases/

@wborn, @kaikreuzer
Checkstyle 11 requires Java 17.
How do we proceed?

I cannot remember right now why we still require Java 11 here. Can you pls. give me a hint?

@wborn
Copy link
Member

wborn commented Aug 24, 2025

See openhab/openhab-distro#1540

@holgerfriedrich
Copy link
Member Author

@wborn, thanks!
Couldn't we switch to this fork https://mvnrepository.com/artifact/io.github.mavenplugins/unleash-maven-plugin/3.3.0 as mentioned openhab/openhab-distro#1475 (comment)?

Where do we define the version and source of the unleash plugin? Is one from the infrastructure-repo used? (Sorry, cannot see the connection yet. Is it pulled in in the Jenkins job only?)

@wborn
Copy link
Member

wborn commented Aug 24, 2025

It's in the super POM:

https://github.com/openhab/infrastructure/blob/584bc58b00260c73613c51f13bfb55cf784ba3c3/pom.xml#L59

We probably want to override the version and test it in the sandbox build first, before going through the hassle of releasing the super POM and finding out there are issues.

We also need to make sure it works with 4.3.x, 5.0.x branches or release a super POM with a version outside of the ranges used by those branches.

Upgrade checkstyle from 10.26.1 to 11.0.1

Changlog:
https://github.com/checkstyle/checkstyle/releases/

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants