-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add precompiled v2.1.0 stable docs version #552
Conversation
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
- _config.yml base change - _includes/base.html base change - usermenu change for generated addons urls Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Good start!
|
Hey Kai, Regarding your comments:
|
Yes, but my main concern is that the button is simply huge (also compared to the menus and other parts) and thus adds a lot of white space that is wasted on small screens. |
Apologies for my delay in reply. It's been a busy period, but can see you've been busier 😃 ! I think this is as best as we can do whilst hosting on GitHub, I haven't seen any other way of doing this so the changes look good to me. A couple of non-blocking points:
|
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
cba5d32
to
f889932
Compare
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
4e01607
to
ca55026
Compare
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Hey guys,
The whole PR is tested and ready to merge. |
Nice! I think this is good now. I can't press the approve button just yet because my browser crashes when Im on the review page. 😐 Will try to use my main PC tommorow evening in which I can also test what it looks like serving to a couple of mobile devices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it looks like it works well! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works good.
Can we merge or do you want @kaikreuzer to approve that too @ThomDietrich ?
Let's merge then - many thanks @ThomDietrich! |
Following the principle: Better than nothing.
This is a first approach in solving #520 here and now.
The PR includes a precompiled version of tag 2.1.0 as the new subfolder "2.1.0".
The PR also includes buttons to switch the version shown.
Modifications applied to 2.1.0 (will need to be addressed in the form of version-branch commits later):
Known limitation: Generation of the button link is derived from the current URL. If the location of an older article was different or the article didn't exist yet, a 404 error will be shown (e.g. https://docs.openhab.org/2.1.0/addons/bindings/some-brand-new-binding/readme.html).
I'm not striving for perfection with the PR. We should still discuss better options for the long run. See #520