Add new externals, misc #516
Conversation
Signed-off-by: Thomas Dietrich <thomas.dietrich@tu-ilmenau.de>
* openHABian USAGE * alexa-skill USAGE * mycroft-skill USAGE * HABPanel config article persistence -> persistences io -> ios Many minor changes to articles Signed-off-by: Thomas Dietrich <thomas.dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <thomas.dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
addons/uis.md
Outdated
| @@ -21,6 +23,13 @@ title: User Interfaces | |||
| | [iOS App]({{docu}}/addons/uis/apps/ios.html) | The native iOS app to access openHAB on the go. | | |||
| | [Windows 10 App]({{docu}}/addons/uis/apps/windows.html) | The native Windows 10 app to access openHAB on the go. | | |||
|
|
|||
| ## Iconsets | |||
|
|
|||
| Basic UI, Classic UI and all apps present a graphical user interface as defined in [Sitemaps]({{base}}/configuration/sitemaps.html) by the help of [Items]({{base}}/configuration/items.html). | |||
There was a problem hiding this comment.
Consider, "Basic UI, Classic UI and all openHAB apps present a graphical user interface as defined in Sitemaps , with the help of Items.
addons/uis.md
Outdated
| ## Iconsets | ||
|
|
||
| Basic UI, Classic UI and all apps present a graphical user interface as defined in [Sitemaps]({{base}}/configuration/sitemaps.html) by the help of [Items]({{base}}/configuration/items.html). | ||
| Each Item respectively each Sitemap element may be assoziated with an icon visible next to it. |
There was a problem hiding this comment.
I do not understand what you mean by this sentence - consider rewording it.
Consider changing "assoziated" to "associated".
addons/uis.md
Outdated
|
|
||
| Basic UI, Classic UI and all apps present a graphical user interface as defined in [Sitemaps]({{base}}/configuration/sitemaps.html) by the help of [Items]({{base}}/configuration/items.html). | ||
| Each Item respectively each Sitemap element may be assoziated with an icon visible next to it. | ||
| The Classic Icons Set is currently the only set of icons provided. |
There was a problem hiding this comment.
Consider changing to, "Currently, only the Classic Icon Set is provided."
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
|
Thanks @bgilmer77! @kaikreuzer could you please have a final look at the changes to the head of (#480 will come with a later PR) |
|
@kaikreuzer just in case you missed the mentioning. If you don't have the time to do this prior to the SHD, the PR can just as well wait till next week. |
|
Hey @ThomDietrich, I am afraid you are right, I completely missed the mention here, sorry :-( Just tested it and I see the meta-data on the headers being rendered on all add-ons pages:
Am I doing anything wrong? |
|
😲 weird. Seems like the front matter part is rendered which I would guess happens because jekyll didn't identify it as that. Any obvious errors in the md file? I'll fire up my Vagrant machine... |
|
Just quickly went through the PR changes and don't think that any of them would have that effect. |
|
Tested, not seeing the issue.
The only problem I encountered was that the iconset once again failed to build due to the missing data folder (commit not included in PR, no issue) |
|
Maybe an issue with my Jekyll version... Anyhow, the rest looks good, so let's assume that Github does it correctly. |
|
Looks all good! 👍 |
|
Yep, looks good. Thanks! |
@kaikreuzer @mortommy @mboremski @ghys
Closes #62
Resolves #372
Resolves #481
Resolves #495
Resolves #505
Depends openhab/org.openhab.ui.habpanel#222
I missed this one: #480
This PR adds:
Plus many small improvements